SteNicholas commented on code in PR #2481: URL: https://github.com/apache/celeborn/pull/2481#discussion_r1582508098
########## docs/configuration/network-module.md: ########## @@ -0,0 +1,34 @@ +--- +license: | + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + https://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--- + +<!--begin-include--> + +The various transport modules, which can be configured, are: + +| Module | Parent Module | Description | +| ------ | ------------- | ----------- | +| rpc_app | rpc | Configure control plane RPC environment used by Celeborn within the application. For backward compatibility, supports fallback to `rpc` parent module for missing configuration.<br/> Note, this is for RPC environment - see below for other transport modules | Review Comment: @mridulm, I understood that the `rpc_app` is configured for client, and `rpc_service` is configured for server. Therefore, should `MasterClient` use `rpc_app`? Otherwise the network configuration of `MasterClient` and `WorkerServer` in Celeborn Worker may have conflict. Anything missing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
