pan3793 opened a new pull request, #2483:
URL: https://github.com/apache/celeborn/pull/2483
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
Disable SBT ANSI color with option `-no-colors` on extracting info from the
output, to recover the binary tarball package on the CI environment.
### Why are the changes needed?
Most CI tools like GHA and GitLab CI export env `CI=true` on the building
environment. I found an interesting thing: an sbt command with/without env
`CI=true` outputs looks are same, but actually not.
```
$ build/sbt "Show / scalaBinaryVersion"
[info] 2.12
[info] celeborn-service / Show / scalaBinaryVersion
[info] 2.12
[info] celeborn-client / Show / scalaBinaryVersion
[info] 2.12
[info] celeborn-master / Show / scalaBinaryVersion
[info] 2.12
[info] Show / scalaBinaryVersion
[info] 2.12
```
```
$ CI=true build/sbt "Show / scalaBinaryVersion"
[info] 2.12
[info] celeborn-service / Show / scalaBinaryVersion
[info] 2.12
[info] celeborn-client / Show / scalaBinaryVersion
[info] 2.12
[info] celeborn-master / Show / scalaBinaryVersion
[info] 2.12
[info] Show / scalaBinaryVersion
[info] 2.12
```
```
$ build/sbt "Show / scalaBinaryVersion" | awk '/\[info\]/{ver=$2} END{print
ver}'
2.12
```
```
$ CI=true build/sbt "Show / scalaBinaryVersion" | awk '/\[info\]/{ver=$2}
END{print ver}'
```
finally I found when `CI=true`, the sbt output has ASCII colors
```
Using /Users/chengpan/.sdkman/candidates/java/17.0.8-zulu as default
JAVA_HOME.
Note, this will be overridden by -java-home if it is set.
^[[0m[^[[0m^[[0minfo^[[0m] ^[[0m^[[0mwelcome to sbt 1.9.4 (Azul Systems,
Inc. Java 17.0.8)^[[0m
^[[0m[^[[0m^[[0minfo^[[0m] ^[[0m^[[0mloading global plugins from
/Users/chengpan/.sbt/1.0/plugins^[[0m
^[[0m[^[[0m^[[0minfo^[[0m] ^[[0m^[[0mloading settings for project
ne-celeborn-build from plugins.sbt ...^[[0m
^[[0m[^[[0m^[[0minfo^[[0m] ^[[0m^[[0mloading project definition from
/Users/chengpan/Projects/ne-celeborn/project^[[0m
^[[0m[^[[0m^[[0minfo^[[0m] ^[[0m^[[0mloading settings for project
ne-celeborn from version.sbt ...^[[0m
^[[0m[^[[0m^[[0minfo^[[0m] ^[[0m^[[0mset current project to ne-celeborn (in
build file:/Users/chengpan/Projects/ne-celeborn/)^[[0m
^[[0m[^[[0m^[[0minfo^[[0m] ^[[0m^[[0mceleborn-worker / Show /
scalaBinaryVersion^[[0m
^[[0m[^[[0m^[[0minfo^[[0m] ^[[0m^[[0m 2.12^[[0m
^[[0m[^[[0m^[[0minfo^[[0m] ^[[0m^[[0mceleborn-common / Show /
scalaBinaryVersion^[[0m
^[[0m[^[[0m^[[0minfo^[[0m] ^[[0m^[[0m 2.12^[[0m
^[[0m[^[[0m^[[0minfo^[[0m] ^[[0m^[[0mceleborn-service / Show /
scalaBinaryVersion^[[0m
^[[0m[^[[0m^[[0minfo^[[0m] ^[[0m^[[0m 2.12^[[0m
^[[0m[^[[0m^[[0minfo^[[0m] ^[[0m^[[0mceleborn-client / Show /
scalaBinaryVersion^[[0m
^[[0m[^[[0m^[[0minfo^[[0m] ^[[0m^[[0m 2.12^[[0m
^[[0m[^[[0m^[[0minfo^[[0m] ^[[0m^[[0mceleborn-master / Show /
scalaBinaryVersion^[[0m
^[[0m[^[[0m^[[0minfo^[[0m] ^[[0m^[[0m 2.12^[[0m
^[[0m[^[[0m^[[0minfo^[[0m] ^[[0m^[[0mShow / scalaBinaryVersion^[[0m
^[[0m[^[[0m^[[0minfo^[[0m] ^[[0m^[[0m 2.12^[[0m
^[[0J
```
### Does this PR introduce _any_ user-facing change?
No for users who do not have such issues.
### How was this patch tested?
Manually test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
