pan3793 commented on code in PR #2440: URL: https://github.com/apache/celeborn/pull/2440#discussion_r1590550555
########## common/src/main/scala/org/apache/celeborn/common/authentication/PasswdAuthenticationProvider.scala: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.celeborn.common.authentication + +import javax.security.sasl.AuthenticationException + +trait PasswdAuthenticationProvider { + + /** + * The authenticate method is called by the celeborn authentication layer + * to authenticate user & password for their requests. + * If a user is to be granted, return nothing/throw nothing. + * When a user is to be disallowed, throw an appropriate [[AuthenticationException]]. + * + * @param user The username received over the connection request + * @param password The password received over the connection request + * + * @throws AuthenticationException When a user is found to be invalid by the implementation + */ + @throws[AuthenticationException] + def authenticate(user: String, password: String): Unit Review Comment: return a `java.security.Principal` instead. you can refer to Trino's `io.trino.spi.security.HeaderAuthenticator` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
