mridulm commented on code in PR #2456:
URL: https://github.com/apache/celeborn/pull/2456#discussion_r1591287602
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -606,14 +606,15 @@ private ConcurrentHashMap<Integer, PartitionLocation>
registerShuffleInternal(
StatusCode respStatus = Utils.toStatusCode(response.getStatus());
if (StatusCode.SUCCESS.equals(respStatus)) {
ConcurrentHashMap<Integer, PartitionLocation> result =
JavaUtils.newConcurrentHashMap();
- for (int i = 0; i < response.getPartitionLocationsList().size();
i++) {
- PartitionLocation partitionLoc =
-
PbSerDeUtils.fromPbPartitionLocation(response.getPartitionLocationsList().get(i));
- pushExcludedWorkers.remove(partitionLoc.hostAndPushPort());
- if (partitionLoc.hasPeer()) {
-
pushExcludedWorkers.remove(partitionLoc.getPeer().hostAndPushPort());
+ Tuple2<List<PartitionLocation>, List<PartitionLocation>> locations =
+ PbSerDeUtils.fromPbPackedPartitionLocationsPair(
+ response.getPackedPartitionLocationsPair());
Review Comment:
In our internal deployment, we do ensure this - I was not sure how it gets
used typically and if this was a scenario :)
Thanks for clarifying !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
