cfmcgrady commented on code in PR #2494:
URL: https://github.com/apache/celeborn/pull/2494#discussion_r1592253369
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4387,17 +4389,20 @@ object CelebornConf extends Logging {
.withAlternative("celeborn.shuffle.forceFallback.enabled")
.categories("client")
.version("0.3.0")
- .doc(s"Whether force fallback shuffle to Spark's default. This
configuration only takes effect when
${CelebornConf.SPARK_SHUFFLE_FALLBACK_POLICY.key} is
${FallbackPolicy.AUTO.name}.")
+ .doc("Always use spark built-in shuffle implementation. This
configuration is deprecated, " +
+ s"consider configuring
`${CelebornConf.SPARK_SHUFFLE_FALLBACK_POLICY.key}` instead.")
.booleanConf
.createWithDefault(false)
- val SPARK_SHUFFLE_FORCE_FALLBACK_PARTITION_THRESHOLD: ConfigEntry[Long] =
-
buildConf("celeborn.client.spark.shuffle.forceFallback.numPartitionsThreshold")
+ val SPARK_SHUFFLE_FALLBACK_PARTITION_THRESHOLD: ConfigEntry[Long] =
+ buildConf("celeborn.client.spark.shuffle.fallback.numPartitionsThreshold")
.withAlternative("celeborn.shuffle.forceFallback.numPartitionsThreshold")
+
.withAlternative("celeborn.client.spark.shuffle.forceFallback.numPartitionsThreshold")
.categories("client")
- .version("0.3.0")
- .doc(
- s"Celeborn will only accept shuffle of partition number lower than
this configuration value. This configuration only takes effect when
${CelebornConf.SPARK_SHUFFLE_FALLBACK_POLICY.key} is
${FallbackPolicy.AUTO.name}.")
+ .version("0.5.0")
+ .doc(s"Celeborn will only accept shuffle of partition number lower than
this configuration value. " +
Review Comment:
```suggestion
.doc("Celeborn will only accept shuffle of partition number lower than
this configuration value. " +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
