ChenYi015 opened a new pull request, #2509:
URL: https://github.com/apache/celeborn/pull/2509

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] 
Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a 
faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   - Comment license with helm template syntax
   - It's better that all resource names are defined once in `_helpers.tml` and 
refered in other files.
   - Format yaml template files with kubernetes style i.e. yaml sequence does 
not have indentation.
   - Refactor service and stetefulset templates.
   - Add README template file `README.md.gotmpl`, and use 
[helm-docs](https://github.com/norwoodj/helm-docs)  to generate `README.md` 
file automatically.
   - Add `.helmignore` file to specify patterns for files and directories that 
should be ignored when packaging the chart.
   - Add a pre-commit git hook to run to generate the latest helm chart 
README.md file automatically.
   
   ### Why are the changes needed?
   
   As dicussed in #2499.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Local test.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to