RexXiong commented on code in PR #2515:
URL: https://github.com/apache/celeborn/pull/2515#discussion_r1604292428


##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/HARaftServer.java:
##########
@@ -375,6 +386,37 @@ private RaftProperties newRaftProperties(CelebornConf 
conf) {
     return properties;
   }
 
+  private Parameters configureSsl(CelebornConf conf, RaftProperties 
properties, RpcType rpc) {
+
+    if (rpc != SupportedRpcType.GRPC) {
+      LOG.error(
+          "SSL has been disabled for Raft communication between masters. "
+              + "This is only supported when ratis is configured with GRPC");

Review Comment:
   If a rolling upgrade of the master is performed, might there be 
compatibility issues with Netty RPC here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to