RexXiong commented on code in PR #2521:
URL: https://github.com/apache/celeborn/pull/2521#discussion_r1609658187
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -726,6 +726,7 @@ final private[worker] class StorageManager(conf:
CelebornConf, workerSource: Abs
Math.min(diskInfo.configuredUsableSpace - totalUsage,
fileSystemReportedUsableSpace)
logDebug(s"updateDiskInfos workingDirUsableSpace:$workingDirUsableSpace
filemeta:$fileSystemReportedUsableSpace conf:${diskInfo.configuredUsableSpace}
totalUsage:$totalUsage")
diskInfo.setUsableSpace(workingDirUsableSpace)
+ diskInfo.setTotalSpace(totalUsage + workingDirUsableSpace)
Review Comment:
diskInfo.configuredUsableSpace is immutable, but there may be situations
where the disk is shared with other applications， In such cases, totalSpace
might not accurately represent the real space for celeborn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
