RexXiong commented on code in PR #2524:
URL: https://github.com/apache/celeborn/pull/2524#discussion_r1611241134
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionFilesSorter.java:
##########
@@ -629,10 +631,18 @@ public void sort() throws InterruptedException {
for (ShuffleBlockInfo blockInfo : originShuffleBlocks) {
long offset = blockInfo.offset;
long length = blockInfo.length;
- ShuffleBlockInfo sortedBlock = new ShuffleBlockInfo();
- sortedBlock.offset = fileIndex;
- sortedBlock.length = length;
- sortedShuffleBlocks.add(sortedBlock);
+ // combine multiple small length `ShuffleBlockInfo` for same mapId
such that
+ // size of compacted `ShuffleBlockInfo` does not exceed
`shuffleChunkSize`
+ if (!sortedShuffleBlocks.isEmpty()
+ && sortedShuffleBlocks.get(sortedShuffleBlocks.size() -
1).length + length
Review Comment:
can we introduce a variable for
`sortedShuffleBlocks.get(sortedShuffleBlocks.size() - 1)`
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -2958,6 +2960,15 @@ object CelebornConf extends Logging {
.booleanConf
.createWithDefault(true)
+ val WORKER_SHUFFLE_BLOCK_COMPACTION_FACTOR : ConfigEntry[Double] =
+ buildConf("celeborn.shuffle.sortPartition.compactionFactor")
Review Comment:
use `celeborn.worker.sortPartition.block.compactionFactor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
