SteNicholas commented on code in PR #2535:
URL: https://github.com/apache/celeborn/pull/2535#discussion_r1630701837
##########
METRICS.md:
##########
@@ -147,6 +148,7 @@ Here is an example of Grafana dashboard importing.
| PotentialConsumeSpeed | worker |
This value means speed of potential consumption for congestion control.
|
| UserProduceSpeed | worker |
This value means speed of user production for congestion control.
|
| WorkerConsumeSpeed | worker |
This value means speed of worker consumption for congestion control.
|
+| isDecommissioningWorker | worker |
1 means worker decommissioning, 0 means not decommissioning.
|
Review Comment:
The descripition of this metric is confusing that 0 not only means not
decommissioning, but also mean decommissioned. Right? How could the user
distingish this? Meanwhile, if you required to add this metric, please also add
`isShutdowning` metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
