SteNicholas commented on code in PR #2535:
URL: https://github.com/apache/celeborn/pull/2535#discussion_r1630751397
##########
METRICS.md:
##########
@@ -147,6 +148,7 @@ Here is an example of Grafana dashboard importing.
| PotentialConsumeSpeed | worker |
This value means speed of potential consumption for congestion control.
|
| UserProduceSpeed | worker |
This value means speed of user production for congestion control.
|
| WorkerConsumeSpeed | worker |
This value means speed of worker consumption for congestion control.
|
+| isDecommissioningWorker | worker |
1 means worker decommissioning, 0 means not decommissioning.
|
Review Comment:
@leixm, where does the worker metric need to distingish between decommission
and graceful shutdown? There is no shutdown metrics in worker. Meanwhile, since
you want `isDecommissioning` metrics, why does other user not want graceful
shutdown?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
