FMX commented on code in PR #2550:
URL: https://github.com/apache/celeborn/pull/2550#discussion_r1634318501


##########
conf/celeborn-defaults.conf.template:
##########
@@ -16,14 +16,6 @@
 #
 
 # An Example:
-celeborn.rpc.io.mode                             NIO
-celeborn.rpc.io.clientThreads                    8
-celeborn.rpc.io.serverThreads                    8
-celeborn.rpc.io.numConnectionsPerPeer            2
-
-celeborn.push.io.numConnectionsPerPeer           2
-celeborn.worker.push.io.threads                  8
-
 celeborn.metrics.enabled                         true
 
 celeborn.worker.storage.dirs                     
/mnt/disk1,/mnt/disk2,/mnt/disk3,/mnt/disk4,/mnt/disk5

Review Comment:
   NO. This is a config file. The demo of this configuration is in the README 
that shows how to set disktype for different dirs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to