SteNicholas commented on code in PR #2558:
URL: https://github.com/apache/celeborn/pull/2558#discussion_r1638004611
##########
client-mr/mr/src/main/java/org/apache/celeborn/mapreduce/v2/app/MRAppMasterWithCeleborn.java:
##########
@@ -197,5 +199,14 @@ public static void checkJobConf(JobConf conf) {
// Make sure reduces are scheduled only after all map are completed.
conf.setFloat(MRJobConfig.COMPLETED_MAPS_FOR_REDUCE_SLOWSTART, 1.0f);
}
+ String masterEndpointsKey = HadoopUtils.MR_PREFIX +
CelebornConf.MASTER_ENDPOINTS().key();
+ String masterEndpointsVal = conf.get(masterEndpointsKey);
+ if (masterEndpointsVal == null || masterEndpointsVal.isEmpty()) {
+ logger.info(
+ "MRAppMaster sets {} via environment variable {}.",
+ masterEndpointsKey,
+ MASTER_ENDPOINTS_ENV);
+ conf.set(masterEndpointsKey, ensureGetSysEnv(MASTER_ENDPOINTS_ENV));
Review Comment:
@cxzl25, `ensureGetSysEnv` could throw exception when
`CELEBORN_MASTER_ENDPOINTS` is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
