FMX commented on code in PR #2564:
URL: https://github.com/apache/celeborn/pull/2564#discussion_r1642209614
##########
common/src/main/scala/org/apache/celeborn/common/util/Utils.scala:
##########
@@ -414,8 +414,28 @@ object Utils extends Logging {
customHostname = Some(hostname)
}
+ val ipv6AddressPattern = """^\[.*:.*\]$""".r
Review Comment:
According to WIKI(https://en.wikipedia.org/wiki/IPv6_address). An IPv6
address will need to be enclosed in square brackets if it's in network resource
identifiers. Set CELEBORN_LOCAL_IP is an IP address, it should be enclosed in
square brackets. So I think this won't be a problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
