FMX commented on code in PR #2561:
URL: https://github.com/apache/celeborn/pull/2561#discussion_r1642764282
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -717,47 +718,23 @@ private[celeborn] class Worker(
workerInfo.releaseSlots(shuffleKey)
val applicationId = Utils.splitShuffleKey(shuffleKey)._1
if (!workerInfo.getApplicationIdSet.contains(applicationId)) {
- // When the running applications does not contain the application
corresponding to expired shuffle key,
- // resource consumption source should remove lose application gauges.
- removeAppResourceConsumption(applicationId)
- removeAppActiveConnection(applicationId)
Review Comment:
Removal of these methods removeAppResourceConsumption and
removeAppActiveConnection is irrelated with this PR. Why should them be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
