RexXiong commented on code in PR #2590:
URL: https://github.com/apache/celeborn/pull/2590#discussion_r1665845113
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -650,7 +667,8 @@ private ConcurrentHashMap<Integer, PartitionLocation>
registerShuffleInternal(
numRetries--;
}
- return null;
+ throw new CelebornIOException(
Review Comment:
Better not to wrapper CelebornIOException use another CelebornIOException,
You can use ExceptionUtils.wrapAndThrowIOException to cast all exception to
CelebornIOException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
