turboFei commented on code in PR #2599:
URL: https://github.com/apache/celeborn/pull/2599#discussion_r1669818545
##########
pom.xml:
##########
@@ -116,6 +118,9 @@
<jersey.version>2.39.1</jersey.version>
<jetty.version>9.4.52.v20230823</jetty.version>
<jakarta.servlet-api.version>4.0.4</jakarta.servlet-api.version>
+ <!-- openapi-generator dependencies -->
+
<openapitools.jackson-databind-nullable.version>0.2.6</openapitools.jackson-databind-nullable.version>
+ <openapitools.swagger.version>1.6.11</openapitools.swagger.version>
Review Comment:
For maven, the openapi-generator version is 6.6.0, the latest version
supports Java 8.
For sbt, the sbt-openapi-generator version is 5.0.1, the only version
supports Java 8.
And due to openapi-generator 5.0.1 does not support `annotationLibrary`
property to chose the library, likes
```
<annotationLibrary>none</annotationLibrary>
<annotationLibrary>swagger2</annotationLibrary>
```
, so we have to introduce swagger1 dependencies to align the dependency list
for maven and sbt build.
FYI:
https://openapi-generator.tech/docs/generators/java
We can remove swagger1.x dependencies or migrate to swagger2.x after
dropping the support for JDK8 and upgrade the openapi-generator to 7.x+ in the
future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
