zhaostu4 commented on code in PR #2625:
URL: https://github.com/apache/celeborn/pull/2625#discussion_r1677358726
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -1670,6 +1670,11 @@ public ReduceFileGroups updateFileGroup(int shuffleId,
int partitionId)
throws CelebornIOException {
Tuple2<ReduceFileGroups, String> fileGroupTuple =
Review Comment:
I think it would be a little better for the update to be done by the next
task. The code would be more concise. But this is acceptable as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
