SteNicholas commented on code in PR #2630:
URL: https://github.com/apache/celeborn/pull/2630#discussion_r1680937855
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -741,6 +748,31 @@ private[celeborn] class Worker(
})
}
+ private def removeAppResourceConsumption(applicationIds: JHashSet[String]):
Unit = {
+ applicationIds.asScala.foreach { applicationId =>
+ removeResourceConsumptionGauge(
+ ResourceConsumptionSource.DISK_FILE_COUNT,
+ applicationId)
+ removeResourceConsumptionGauge(
+ ResourceConsumptionSource.DISK_BYTES_WRITTEN,
+ applicationId)
+ removeResourceConsumptionGauge(
+ ResourceConsumptionSource.HDFS_FILE_COUNT,
+ applicationId)
+ removeResourceConsumptionGauge(
+ ResourceConsumptionSource.HDFS_BYTES_WRITTEN,
+ applicationId)
+ }
+ }
+
+ private def removeResourceConsumptionGauge(
+ resourceConsumptionName: String,
+ applicationId: String): Unit = {
+ resourceConsumptionSource.removeGauge(
+ resourceConsumptionName,
+ Map(resourceConsumptionSource.applicationLabel -> applicationId))
Review Comment:
@leixm, sorry for forgetting the changes of `removeGauge`. I have updated
`removeAppResourceConsumption` to support removing resource consumption metrics.
BTW, the speed of removing metrics has a significant impact on consuming
expired shuffle keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
