SteNicholas commented on code in PR #2555:
URL: https://github.com/apache/celeborn/pull/2555#discussion_r1682042800
##########
service/src/main/java/org/apache/celeborn/server/common/service/store/db/DbServiceManagerImpl.java:
##########
@@ -61,6 +61,7 @@ public DbServiceManagerImpl(CelebornConf celebornConf,
ConfigService configServe
this.clusterId = createCluster(getClusterInfoFromEnv());
}
+ @SuppressWarnings("JavaUtilDate")
Review Comment:
@venkata91, changing to `Instant` type of [type-handlers are merged in to
mybatis core since
3.4.5](https://stackoverflow.com/questions/25113579/java-8-localdate-mapping-with-mybatis)
support has type compatibility problem for the database implementation of
dynamic config. Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
