venkata91 commented on code in PR #2555:
URL: https://github.com/apache/celeborn/pull/2555#discussion_r1683792044
##########
service/src/main/java/org/apache/celeborn/server/common/service/store/db/DbServiceManagerImpl.java:
##########
@@ -61,6 +61,7 @@ public DbServiceManagerImpl(CelebornConf celebornConf,
ConfigService configServe
this.clusterId = createCluster(getClusterInfoFromEnv());
}
+ @SuppressWarnings("JavaUtilDate")
Review Comment:
Looks like `java.time.Instant` is mapped to TIMESTAMP based on the
[InstantTypeHandlerTest](https://github.com/harawata/mybatis-3/blob/2da2275185e8bb185d51eb522120ac32e5635225/src/test/java/org/apache/ibatis/type/usesjava8/InstantTypeHandlerTest.java).
Looks like it should be handled without needing any changes to
`celeborn-0.5.0-mysql.sql`, no? note: I haven't tried out this myself though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
