akpatnam25 commented on code in PR #2633:
URL: https://github.com/apache/celeborn/pull/2633#discussion_r1687377537
##########
docs/configuration/network.md:
##########
@@ -42,6 +42,7 @@ license: |
| celeborn.<role>.rpc.dispatcher.threads | <value of
celeborn.rpc.dispatcher.threads> | false | Threads number of message
dispatcher event loop for roles | | |
| celeborn.io.maxDefaultNettyThreads | 64 | false | Max default netty threads
| 0.3.2 | |
| celeborn.network.bind.preferIpAddress | true | false | When `true`, prefer
to use IP address, otherwise FQDN. This configuration only takes effects when
the bind hostname is not set explicitly, in such case, Celeborn will find the
first non-loopback address to bind. | 0.3.0 | |
+| celeborn.network.bind.wildcardAddress | false | false | When `true`, the
bind address will be set to a wildcard address, while the advertise address
will remain as whatever is set by `celeborn.network.bind.preferIpAddress`. This
is helpful in dual-stack environments, where the service must listen to both
IPv4 and IPv6 clients. | 0.6.0 | |
Review Comment:
Essentially, these are the 2 scenarios:
1. `celeborn.network.bind.wildcardAddress=true`
- RPC and HTTP servers bind to wildcard address
- Advertise address (either hostname or ip) is determined by
`celeborn.network.bind.preferIpAddress`
2. `celeborn.network.bind.wildcardAddress=false`
- RPC and HTTP servers bind to the address (either hostname or ip)
determined by `celeborn.network.bind.preferIpAddress`.
- Advertise address either hostname or ip) determined by
`celeborn.network.bind.preferIpAddress`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
