venkata91 commented on code in PR #2633:
URL: https://github.com/apache/celeborn/pull/2633#discussion_r1690102460
##########
common/src/main/scala/org/apache/celeborn/common/rpc/netty/NettyRpcEnv.scala:
##########
@@ -390,8 +390,13 @@ private[celeborn] class NettyRpcEnvFactory extends
RpcEnvFactory with Logging {
new
JavaSerializer(celebornConf).newInstance().asInstanceOf[JavaSerializerInstance]
val nettyEnv = new NettyRpcEnv(config, javaSerializerInstance)
val startNettyRpcEnv: Int => (NettyRpcEnv, Int) = { actualPort =>
- logInfo(s"Starting RPC Server [${config.name}] on
${config.bindAddress}:$actualPort " +
- s"with advisor endpoint ${config.advertiseAddress}:$actualPort")
+ if (celebornConf.bindWildcardAddress) {
+ logInfo(s"Starting RPC Server [${config.name}] on wildcard address
with port" +
Review Comment:
Just a suggestion: it would make it clearer for others if added as a `static
final WILDCARD_ADDRESS = null` and use it in both `HttpService` and `RpcEnv` as
well with a comment explaining what it is for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
