pan3793 commented on code in PR #2646: URL: https://github.com/apache/celeborn/pull/2646#discussion_r1692446156
########## master/src/main/scala/org/apache/celeborn/service/deploy/master/clustermeta/ha/MasterNode.scala: ########## @@ -41,15 +41,9 @@ case class MasterNode( def rpcEndpoint: String = rpcHost + ":" + rpcPort - def rpcIpEndpoint: String = rpcAddr.getAddress.getHostAddress + ":" + rpcPort - def internalRpcEndpoint: String = rpcHost + ":" + internalRpcPort - def internalRpcIpEndpoint: String = rpcAddr.getAddress.getHostAddress + ":" + rpcPort - lazy val ratisAddr = MasterNode.createSocketAddr(ratisHost, ratisPort) - - lazy val rpcAddr = MasterNode.createSocketAddr(rpcHost, rpcPort) Review Comment: @RexXiong this is added in https://github.com/apache/celeborn/commit/993d3f2587b1c9cd8acd1a593a186d8044487c14, seems was never used -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
