pan3793 commented on code in PR #2647:
URL: https://github.com/apache/celeborn/pull/2647#discussion_r1694480221
##########
client-mr/mr/src/main/java/org/apache/hadoop/mapreduce/task/reduce/CelebornShuffleConsumer.java:
##########
@@ -114,6 +114,16 @@ private ShuffleClientMetrics createMetrics(
} catch (Exception e) {
// ignore this exception because the createMetrics might use hadoop2
}
+
+ // for hadoop 3.1
Review Comment:
can you mention the JIRA ticket in comments too? there are a lot of vender
customized hadoop that may not align with apache hadoop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]