reswqa commented on code in PR #2662:
URL: https://github.com/apache/celeborn/pull/2662#discussion_r1701854112
##########
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/AbstractRemoteShuffleInputGateFactory.java:
##########
@@ -90,18 +89,21 @@ public IndexedInputGate create(
SupplierWithException<BufferPool, IOException> bufferPoolFactory =
createBufferPoolFactory(networkBufferPool, numBuffersPerGate,
supportFloatingBuffers);
- BufferDecompressor bufferDecompressor =
- new BufferDecompressor(networkBufferSize,
celebornConf.shuffleCompressionCodec().name());
- return createInputGate(owningTaskName, gateIndex, igdd, bufferPoolFactory,
bufferDecompressor);
+ return createInputGate(
+ owningTaskName,
+ gateIndex,
+ igdd,
+ bufferPoolFactory,
+ celebornConf.shuffleCompressionCodec().name());
Review Comment:
1.20 using enum `CompressionCodec` instead of string to construct
`BufferDecompressor`.
##########
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/AbstractRemoteShuffleInputGateFactory.java:
##########
@@ -90,18 +89,21 @@ public IndexedInputGate create(
SupplierWithException<BufferPool, IOException> bufferPoolFactory =
createBufferPoolFactory(networkBufferPool, numBuffersPerGate,
supportFloatingBuffers);
- BufferDecompressor bufferDecompressor =
- new BufferDecompressor(networkBufferSize,
celebornConf.shuffleCompressionCodec().name());
- return createInputGate(owningTaskName, gateIndex, igdd, bufferPoolFactory,
bufferDecompressor);
+ return createInputGate(
+ owningTaskName,
+ gateIndex,
+ igdd,
+ bufferPoolFactory,
+ celebornConf.shuffleCompressionCodec().name());
Review Comment:
1.20 use enum `CompressionCodec` instead of string to construct
`BufferDecompressor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
