SteNicholas opened a new pull request, #2668:
URL: https://github.com/apache/celeborn/pull/2668

   ### What changes were proposed in this pull request?
   
   `Worker#listTopDiskUseApps` should return 
`celeborn.metrics.app.topDiskUsage.count` applications.
   
   ### Why are the changes needed?
   
   `Worker#listTopDiskUseApps` returns 2x 
`celeborn.metrics.app.topDiskUsage.count` application, which is not same as 
`celeborn.metrics.app.topDiskUsage.count` configuration at present. Meanwhile, 
`Worker#listTopDiskUseApps` reuses `StorageManager#topAppDiskUsage` method to 
get the top application list used for estimated application disk usage. 
Therefore, `Worker#listTopDiskUseApps` should return 
celeborn.metrics.app.topDiskUsage.count applications.
   
   ```
   $ curl http://celeborn-worker:9096/listTopDiskUsedApps|grep used|wc -l
   100
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   ```
   $ curl http://celeborn-worker:9096/listTopDiskUsedApps|grep used|wc -l
   50
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to