ChenYi015 commented on PR #2650:
URL: https://github.com/apache/celeborn/pull/2650#issuecomment-2275776763

   > For my opinion, volumeClaimTemplates is needed but host path and empty 
path is more general for most of situations. It's better to add it as an option 
instead of the only choice.
   
   @lianneli Thanks for the advice. Though, I think volumes with type 
`hostPath` and `emptyDir` are still supported by `[master|worker].volumes`. 
Before, the configuration is like this:
   
   ```yaml
   volumes:
     master:
     - mountPath: /mnt/celeborn_ratis
       hostPath: /mnt/celeborn_ratis
       type: hostPath
       capacity: 100Gi
     worker:
     - mountPath: /mnt/disk1
       hostPath: /mnt/disk1
       type: hostPath
       diskType: SSD
       capacity: 100Gi
   ```
   
   After, it will be like this:
   
   ```yaml
   master:
     volumes:
     - name: celeborn-ratis
       hostPath: 
         path: /mnt/celeborn_ratis
     volumeMounts:
     - name: celeborn-ratis
       mountPath: /mnt/celeborn_ratis
   
   worker:
     volumes:
     - name: disk1
       hostPath:
         path: /mnt/disk1
     volumeMounts:
     - name: disk1
       mountPath: /mnt/disk1
   
   celeborn:
     celeborn.worker.storage.dirs=/mnt/disk1:disktype=SSD:capacity=100Gi
   ```
   
   The difference is that we need to configure `celeborn.worker.storage.dirs` 
manually if we use `hostPath` or `emptyDir`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to