waitinfuture commented on code in PR #2639:
URL: https://github.com/apache/celeborn/pull/2639#discussion_r1713113839


##########
tests/spark-it/src/test/scala/org/apache/celeborn/tests/spark/CelebornFetchFailureSuite.scala:
##########
@@ -17,10 +17,13 @@
 
 package org.apache.celeborn.tests.spark
 
-import java.io.File
+import java.io.{File, IOException}
+import java.util.concurrent.TimeUnit

Review Comment:
   nit: unused import



##########
tests/spark-it/src/test/scala/org/apache/celeborn/tests/spark/CelebornFetchFailureSuite.scala:
##########
@@ -297,4 +300,165 @@ class CelebornFetchFailureSuite extends AnyFunSuite
       sparkSession.stop()
     }
   }
+
+  test(s"celeborn spark integration test - resubmit an unordered barrier stage 
with throwsFetchFailure enabled") {
+    val sparkConf = new 
SparkConf().setAppName("rss-demo").setMaster("local[2]")
+    val sparkSession = SparkSession.builder()
+      .config(updateSparkConf(sparkConf, ShuffleMode.HASH))
+      .config("spark.sql.shuffle.partitions", 2)
+      .config("spark.celeborn.shuffle.forceFallback.partition.enabled", false)
+      .config("spark.celeborn.shuffle.enabled", "true")

Review Comment:
   nit: seems this config is not defined by Celeborn?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to