FMX commented on code in PR #2690:
URL: https://github.com/apache/celeborn/pull/2690#discussion_r1719588437
##########
master/src/main/proto/Resource.proto:
##########
@@ -83,6 +83,7 @@ message DiskInfo {
required int32 status = 5;
required int64 avgFetchTime = 6;
required int32 storageType =7;
+ required int64 totalSpace = 8;
Review Comment:
Using optional will be better. Adding a required field will block the
rolling upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
