RexXiong commented on PR #2609: URL: https://github.com/apache/celeborn/pull/2609#issuecomment-2300108707
> Looks reasonable to me. > > +CC @waitinfuture and @RexXiong as well. > > My only hesitation is whether we can generalize how we are handling `testRandomPushForStageRerun` ... it is hyper specific to that test. Agree. IMO we should eliminate this test from the standard read/write code. We only need to ensure that a different attempt ID is used for shuffle writes, as Distinguishing the output data with different attempt IDs aligns with our previous approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
