SteNicholas opened a new pull request, #2715: URL: https://github.com/apache/celeborn/pull/2715
### What changes were proposed in this pull request? `MasterClient#sendMessageInner` should throw `Throwable` for `celeborn.masterClient.maxRetries` is 0. ### Why are the changes needed? `MasterClient#sendMessageInner` causes `NullPointerException` with `Cannot throw exception because "throwable" is null` for `celeborn.masterClient.maxRetries` is 0. ``` 2024-08-27T19:07:03.7681998Z 24/08/27 19:07:03,767 ERROR [celeborn-dispatcher-2] MasterClient: Send rpc with failure, has tried 0, max try 0! 2024-08-27T19:07:03.7693891Z 24/08/27 19:07:03,767 ERROR [celeborn-dispatcher-2] LifecycleManager: AskSync RegisterShuffle for app-1-1 failed. 2024-08-27T19:07:03.7695444Z java.lang.NullPointerException: Cannot throw exception because "throwable" is null 2024-08-27T19:07:03.7696857Z at org.apache.celeborn.common.client.MasterClient.sendMessageInner(MasterClient.java:167) 2024-08-27T19:07:03.7698346Z at org.apache.celeborn.common.client.MasterClient.askSync(MasterClient.java:121) 2024-08-27T19:07:03.7699927Z at org.apache.celeborn.client.LifecycleManager.requestMasterRequestSlots(LifecycleManager.scala:1621) 2024-08-27T19:07:03.7701836Z at org.apache.celeborn.client.LifecycleManager.requestMasterRequestSlotsWithRetry(LifecycleManager.scala:1610) 2024-08-27T19:07:03.7703976Z at org.apache.celeborn.client.LifecycleManager.org$apache$celeborn$client$LifecycleManager$$offerAndReserveSlots(LifecycleManager.scala:642) 2024-08-27T19:07:03.7706423Z at org.apache.celeborn.client.LifecycleManager$$anonfun$receiveAndReply$1.applyOrElse(LifecycleManager.scala:338) 2024-08-27T19:07:03.7708030Z at org.apache.celeborn.common.rpc.netty.Inbox.processInternal(Inbox.scala:119) 2024-08-27T19:07:03.7709352Z at org.apache.celeborn.common.rpc.netty.Inbox.$anonfun$process$1(Inbox.scala:218) 2024-08-27T19:07:03.7710619Z at org.apache.celeborn.common.rpc.netty.Inbox.safelyCall(Inbox.scala:314) 2024-08-27T19:07:03.7711825Z at org.apache.celeborn.common.rpc.netty.Inbox.process(Inbox.scala:218) 2024-08-27T19:07:03.7713139Z at org.apache.celeborn.common.rpc.netty.Dispatcher$MessageLoop.run(Dispatcher.scala:238) 2024-08-27T19:07:03.7714639Z at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) 2024-08-27T19:07:03.7716148Z at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) 2024-08-27T19:07:03.7717292Z at java.base/java.lang.Thread.run(Thread.java:840) ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? `MasterClientSuiteJ#testSendMessageWithoutHAWithoutRetry` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
