SteNicholas commented on code in PR #2714: URL: https://github.com/apache/celeborn/pull/2714#discussion_r1736091263
########## worker/src/main/scala/org/apache/celeborn/service/deploy/worker/WorkerSource.scala: ########## @@ -72,6 +72,8 @@ class WorkerSource(conf: CelebornConf) extends AbstractSource(conf, MetricsSyste addTimer(REPLICA_REGION_START_TIME) addTimer(PRIMARY_REGION_FINISH_TIME) addTimer(REPLICA_REGION_FINISH_TIME) + addTimer(PRIMARY_SEGMENT_START_TIME) Review Comment: The introduced metrics could create another pull request, otherwise please add these metrics in document and `celeborn-dashboard.json`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
