cfmcgrady opened a new pull request, #2717:
URL: https://github.com/apache/celeborn/pull/2717

   
   
   backport https://github.com/apache/celeborn/pull/2609 to branch-0.4
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] 
Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a 
faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   
   Let attemptNumber = (stageAttemptId << 16) | taskAttemptNumber, to 
differentiate map results with only different stageAttemptId.
   
   
   ### Why are the changes needed?
   
   
   If we can't differentiate map tasks with only different stageAttemptId, it 
may lead to mixed reading of two map tasks' shuffle write batches during 
shuffle read, causing data correctness issue.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   
   ### How was this patch tested?
   
   
   
   Add ut: 
org.apache.spark.shuffle.celeborn.SparkShuffleManagerSuite#testWrongSparkConf_MaxAttemptLimit
   
   Closes #2609 from jiang13021/spark_stage_attempt_id.
   
   Lead-authored-by: jiang13021 <[email protected]>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to