SteNicholas commented on code in PR #2716:
URL: https://github.com/apache/celeborn/pull/2716#discussion_r1742528842


##########
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/readclient/FlinkShuffleClientImpl.java:
##########
@@ -516,6 +552,44 @@ public void regionFinish(int shuffleId, int mapId, int 
attemptId, PartitionLocat
         });
   }
 
+  public void segmentStart(
+      int shuffleId,
+      int mapId,
+      int attemptId,
+      int subPartitionId,
+      int segmentId,
+      PartitionLocation location)
+      throws IOException {
+    final String mapKey = Utils.makeMapKey(shuffleId, mapId, attemptId);
+    final PushState pushState = pushStates.computeIfAbsent(mapKey, (s) -> new 
PushState(conf));
+    retrySendMessage(
+        () -> {
+          final String shuffleKey = Utils.makeShuffleKey(appUniqueId, 
shuffleId);
+          logger.debug(
+              "SegmentStart for shuffle {} map {} attemptId {} locationId {}.",

Review Comment:
   Add `subPartitionId` and `segmentId` in log.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to