mridulm commented on code in PR #2699:
URL: https://github.com/apache/celeborn/pull/2699#discussion_r1743165584
##########
cli/src/main/scala/org/apache/celeborn/cli/config/CliConfigManager.scala:
##########
@@ -27,8 +27,11 @@ import org.apache.celeborn.common.util.Utils
case class CliConfig(cliConfigData: Map[String, String])
object CliConfigManager {
- val cliConfigFilePath: String =
- s"${sys.env.getOrElse("EXAMPLE_CONF_DIR",
sys.env("HOME"))}/celeborn-cli.conf"
+ val cliConfigFilePath: String = {
+ val basePath = sys.env.getOrElse("CELEBORN_HOME", sys.env("HOME"))
Review Comment:
`CELEBORN_HOME` would be set - so cli will try writing to
$CELEBORN_HOME/celeborn-cli.conf : and fail, as it would usually be read-only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
