pan3793 commented on code in PR #2713:
URL: https://github.com/apache/celeborn/pull/2713#discussion_r1755913059
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -1723,6 +1728,23 @@ object CelebornConf extends Logging {
.intConf
.createOptional
+ val NETWORK_WILDCARD_ADDRESS_BIND: ConfigEntry[Boolean] =
+ buildConf("celeborn.network.bind.wildcardAddress")
+ .categories("network")
+ .version("0.6.0")
+ .doc("When `true`, the bind address will be set to a wildcard address,
while the advertise address will " +
Review Comment:
Is "wildcard address" an idiomatic networking term used to represent an
arbitrary address(`0.0.0.0` in IPv4 case and `::0` in IPv6)? I also saw [a
similar
question](https://github.com/apache/celeborn/pull/2633#discussion_r1690084955)
in the previous PR.
I'm not sure what the official or most popular names of `0.0.0.0` and `::0`
are, according to https://en.wikipedia.org/wiki/0.0.0.0, the most common one
might be `INADDR_ANY`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
