RexXiong commented on code in PR #2737:
URL: https://github.com/apache/celeborn/pull/2737#discussion_r1759039747
##########
conf/dynamicConfig.yaml.template:
##########
@@ -16,12 +16,15 @@
#
- level: SYSTEM
config:
- celeborn.worker.directMemoryRatioToPauseReceive: 0.75
Review Comment:
> seems this config item is not dynamic, I wonder whether it works now
yes，seems can be dynamic，but not supported yet.
##########
docs/configuration/index.md:
##########
@@ -168,7 +168,7 @@ If `celeborn.worker.flusher.buffer.size` is 256 KB, we can
have total slots up t
## Rack Awareness
-Celeborn can be rack-aware by setting
`celeborn.client.reserveSlots.rackware.enabled` to `true` on client side.
+Celeborn can be rack-aware by setting
`celeborn.client.reserveSlots.rackaware.enabled` to `true` on client side.
Review Comment:
We can either keep this or remove it. However, if we decide to remove it, we
will need to update the migration guide accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
