SteNicholas commented on code in PR #2741:
URL: https://github.com/apache/celeborn/pull/2741#discussion_r1768266253
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/MapPartitionDataWriter.java:
##########
@@ -40,19 +40,19 @@
/*
* map partition file writer, it will create index for each partition
*/
-public final class MapPartitionDataWriter extends PartitionDataWriter {
+public class MapPartitionDataWriter extends PartitionDataWriter {
private static final Logger logger =
LoggerFactory.getLogger(MapPartitionDataWriter.class);
- private int numSubpartitions;
- private int currentDataRegionIndex;
- private boolean isBroadcastRegion;
- private long[] numSubpartitionBytes;
- private ByteBuffer indexBuffer;
- private int currentSubpartition;
- private long totalBytes;
- private long regionStartingOffset;
- private FileChannel indexChannel;
- private volatile boolean isRegionFinished = true;
+ protected int numSubpartitions;
Review Comment:
Why does this change all privates to protected? If other needs, please add
the getter/setter of the variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
