turboFei commented on code in PR #2756:
URL: https://github.com/apache/celeborn/pull/2756#discussion_r1769633424
##########
service/src/main/scala/org/apache/celeborn/server/common/http/api/CelebornOpenApiResource.scala:
##########
@@ -81,9 +82,10 @@ class CelebornOpenApiResource extends BaseOpenApiResource
with ApiRequestContext
}
}
- private def setCelebornOpenAPIDefinition(openApi: OpenAPI, requestBaseUrl:
String): OpenAPI = {
- // TODO: to improve when https is enabled.
- val apiUrls = List(requestBaseUrl,
s"http://${httpService.connectionUrl}/";).distinct
+ private def setCelebornOpenAPIDefinition(openApi: OpenAPI, requestBaseUri:
URI): OpenAPI = {
+ val httpScheme = if (httpService.httpSslEnabled()) "https:" else "http:"
+ val requestBaseUrl = s"$httpScheme${requestBaseUri.getSchemeSpecificPart}"
+ val apiUrls = List(requestBaseUrl,
s"$httpScheme//${httpService.connectionUrl}/").distinct
Review Comment:
```
scala> val uri = new java.net.URI("https://celeborn.vip.com:9098/";)
val uri: java.net.URI = https://celeborn.vip.com:9098/
scala> uri.getSchemeSpecificPart
val res0: String = //celeborn.vip.com:9098/
scala> "https:" + uri.getSchemeSpecificPart
val res1: String = https://celeborn.vip.com:9098/
scala>
scala>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
