waitinfuture commented on code in PR #2672:
URL: https://github.com/apache/celeborn/pull/2672#discussion_r1770219790
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -808,7 +808,8 @@ private[celeborn] class Master(
disks,
userResourceConsumption,
requestId)
- logInfo(s"Registered worker $workerToRegister.")
+ logInfo(
+ s"Registered worker:
${workerToRegister.workerInfoToString(conf.humanFriendlyLogEnabled)}.")
Review Comment:
Better to cache the value of `conf.humanFriendlyLogEnabled`. Although
logging here is not frequent, I think it's a better practice :)
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -858,7 +858,9 @@ final private[worker] class StorageManager(conf:
CelebornConf, workerSource: Abs
diskInfo.updateFlushTime()
diskInfo.updateFetchTime()
}
- logInfo(s"Updated diskInfos:\n${disksSnapshot().mkString("\n")}")
+
+ val (prefix, delimiter, suffix) =
Utils.getFormattingTokens(conf.humanFriendlyLogEnabled)
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
