SteNicholas commented on code in PR #2711:
URL: https://github.com/apache/celeborn/pull/2711#discussion_r1774757651
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -435,6 +435,14 @@ private[celeborn] class Worker(
0
}
}
+ // Unreleased shuffle count when worker was decommissioned
+ workerSource.addGauge(WorkerSource.UNRELEASED_SHUFFLE_COUNT) { () =>
+ if (shutdown.get() && workerStatusManager.currentWorkerStatus.getState ==
State.Exit) {
Review Comment:
```suggestion
if (shutdown.get() && workerStatusManager.currentWorkerStatus.getState
== State.InDecommission ||
workerStatusManager.currentWorkerStatus.getState ==
State.InDecommissionThenIdle) {
```
The status should be `InDecommission` or `InDecommissionThenIdle`. Right?
Because the description of this metric is that `Unreleased shuffle count when
worker was decommissioned. `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
