cxzl25 commented on code in PR #2759:
URL: https://github.com/apache/celeborn/pull/2759#discussion_r1776720266
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/HARaftServer.java:
##########
@@ -200,9 +200,7 @@ public static HARaftServer newMasterRatisServer(
RaftPeer localRaftPeer =
RaftPeer.newBuilder()
.setId(localRaftPeerId)
- // TODO(CELEBORN-1525): Once Ratis 3.2.0 is released and we move
to it, we
- // should remove address2String and change this to
.setAddress(ratisAddr)
- .setAddress(address2String(ratisAddr))
+ .setAddress(ratisAddr)
Review Comment:
Should the `address2String` method also be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
