turboFei commented on code in PR #2764:
URL: https://github.com/apache/celeborn/pull/2764#discussion_r1778300129
##########
service/src/main/scala/org/apache/celeborn/server/common/HttpService.scala:
##########
@@ -348,9 +347,13 @@ abstract class HttpService extends Service with Logging {
if (metricsSystem.running) {
metricsSystem.getServletContextHandlers.foreach { handler =>
+ logInfo(s"Adding metrics servlet handler with path
${handler.getContextPath}")
httpServer.addHandler(handler)
}
}
+
+ // start the http server after all handlers are added
+ httpServer.start()
Review Comment:
how about starting/exposing the http endpoint after all handlers added?
@waitinfuture
In our use case, there is an agent to collect the celeborn metrics
periodically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
