RexXiong commented on code in PR #2817:
URL: https://github.com/apache/celeborn/pull/2817#discussion_r1804343120
##########
service/src/main/java/org/apache/celeborn/server/common/service/config/ConfigService.java:
##########
@@ -108,6 +109,13 @@ default DynamicConfig getTenantUserConfigFromCache(String
tenantId, String userI
*/
void refreshCache() throws IOException;
+ /**
+ * Registers a listener to be called when the configuration is updated.
+ *
+ * @param listener the listener to be registered
+ */
+ void registerListenerOnConfigUpdate(Consumer<ConfigService> listener);
Review Comment:
If we don't have a listener interface, perhaps using Runnable would be more
suitable, as we wouldn't need to accept a ConfigService.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
