pan3793 commented on code in PR #2815:
URL: https://github.com/apache/celeborn/pull/2815#discussion_r1804633465
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/memory/ReadBufferDispatcher.java:
##########
@@ -132,4 +106,70 @@ public void close() {
stopFlag = true;
requests.clear();
}
+
+ private class DispatcherRunnable implements Runnable {
+ private final MemoryManager memoryManager;
+
+ public DispatcherRunnable(MemoryManager memoryManager) {
+ this.memoryManager = memoryManager;
+ }
+
+ @Override
+ public void run() {
+ while (!stopFlag) {
+ try {
+ ReadBufferRequest request = null;
Review Comment:
maybe
```
@Override
public void run() {
while (!stopFlag) {
try {
call another_method
} catch catch (Throwable e) {
logger.error("Read buffer dispatcher encountered error: {}",
e.getMessage(), e);
}
}
}
void another_method() {
balabala
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
