mridulm commented on PR #2826: URL: https://github.com/apache/celeborn/pull/2826#issuecomment-2427299615
> IMO, Although this PR can solve the issue, I think it's better for the master side to directly access the secrets from the applicationMeta in AbstractMetaManager. What I mean is that the master doesn't need to redundantly store the secret contents in the secrets object of SecretRegistryImpl. @RexXiong, that would imply we dont have any other impl of `IMetadataHandler` - only subclasses of `AbstractMetaManager`. It is a reasonable alternative approach though, I agree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
