RexXiong commented on code in PR #2820:
URL: https://github.com/apache/celeborn/pull/2820#discussion_r1812022652
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/MapPartitionData.java:
##########
@@ -59,20 +59,25 @@ class MapPartitionData implements
MemoryManager.ReadBufferTargetChangeListener {
private final BufferQueue bufferQueue = new BufferQueue();
private AtomicBoolean bufferQueueInitialized = new AtomicBoolean(false);
private MemoryManager memoryManager = MemoryManager.instance();
- private Consumer<Long> recycleStream;
+ protected Consumer<Long> recycleStream;
private int minReadBuffers;
private int maxReadBuffers;
private int minBuffersToTriggerRead;
private AtomicBoolean hasReadingTask = new AtomicBoolean(false);
+ // if requireSubpartitionId is set to true, means that the buffer sent to
client
+ // by the worker should be SubpartitionReadData rather than ReadData
+ protected boolean requireSubpartitionId;
Review Comment:
requireSubpartitionId is necessary only when using SegmentMapPartitionData
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
