turboFei commented on code in PR #2839:
URL: https://github.com/apache/celeborn/pull/2839#discussion_r1817439677
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -90,6 +94,129 @@ public abstract class AbstractMetaManager implements
IMetadataHandler {
public final ConcurrentHashMap<String, ApplicationMeta> applicationMetas =
JavaUtils.newConcurrentHashMap();
+ public Collection<WorkerInfo> getWorkers() {
+ return Collections.unmodifiableCollection(workersMap.values());
Review Comment:
always return unmodified collections for the get methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
