s0nskar commented on code in PR #2727:
URL: https://github.com/apache/celeborn/pull/2727#discussion_r1820890079
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/quota/QuotaManager.scala:
##########
@@ -39,10 +39,23 @@ class QuotaManager(celebornConf: CelebornConf,
configService: ConfigService) ext
}
}
- def checkQuotaSpaceAvailable(
+ private def getQuotaWithWatermark(
userIdentifier: UserIdentifier,
- resourceResumption: ResourceConsumption): (Boolean, String) = {
+ quotaWatermark: Double): Quota = {
val quota = getQuota(userIdentifier)
+ Quota(
+ (quota.diskBytesWritten * quotaWatermark).toLong,
Review Comment:
@waitinfuture wdyt about this? IMO this should be a must have to avoid
interrupting the user/tenant jobs in bulk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
